Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add samples for soft delete (objects) #2754

Merged
merged 7 commits into from
Dec 6, 2024
Merged

docs: add samples for soft delete (objects) #2754

merged 7 commits into from
Dec 6, 2024

Conversation

JesseLovelace
Copy link
Contributor

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. labels Oct 7, 2024
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Oct 7, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@BenWhitehead BenWhitehead changed the title feat: add samples for soft delete (objects) docs: add samples for soft delete (objects) Oct 10, 2024
sydney-munro
sydney-munro approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@sydney-munro sydney-munro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with 2 small comments.

samples/snippets/src/main/java/com/example/storage/bucket/DisableSoftDelete.java Outdated Show resolved Hide resolved
samples/snippets/src/main/java/com/example/storage/bucket/SetSoftDeletePolicy.java Outdated Show resolved Hide resolved
@sydney-munro
Copy link
Collaborator

approved with 2 small comments.

LGTM

@JesseLovelace JesseLovelace merged commit 41bc807 into main Dec 6, 2024
21 checks passed
@JesseLovelace JesseLovelace deleted the softdelsamps branch December 6, 2024 18:20
@release-please release-please bot mentioned this pull request Dec 5, 2024
Merged
This was referenced Dec 6, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-munro sydney-munro sydney-munro approved these changes

Assignees

@bourgeoisor bourgeoisor

Labels
api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JesseLovelace @sydney-munro @bourgeoisor